Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smurfing Queens #4166

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Smurfing Queens #4166

merged 1 commit into from
Aug 12, 2023

Conversation

morrowwolf
Copy link
Member

@morrowwolf morrowwolf commented Aug 11, 2023

About the pull request

This PR changes the tags at end of round from a queen's CKEY to their in round designations (prefix-number-postfix) so as to allow for people who would like to play queen without their ckey attached. Those who want to be known can still be known via their tag.

Explain why it's good for the game

I want to play Queen without getting pinged 20 times post round in #LRC

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 Morrow
add: At end of round it now shows a Queen's prefix/postfix rather than their ckey
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Aug 11, 2023
@harryob harryob added this pull request to the merge queue Aug 12, 2023
Merged via the queue into cmss13-devs:master with commit 1eebb2c Aug 12, 2023
27 checks passed
cm13-github added a commit that referenced this pull request Aug 12, 2023
@morrowwolf morrowwolf deleted the smurfing-queens branch August 12, 2023 22:17
github-merge-queue bot pushed a commit that referenced this pull request Aug 14, 2023
# About the pull request

This PR is a followup to #4166 removing queen ckeys from attribution;
now it is the designation like that PR uses:

![image](https://github.com/cmss13-devs/cmss13/assets/76988376/8f9e44a7-c768-4048-9e00-005794720b3c)

# Explain why it's good for the game

Consistency - if queens aren't going to be known by ckey at end game,
then jellies should behave the same.

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>


![image](https://github.com/cmss13-devs/cmss13/assets/76988376/0817ea74-bb07-40ed-b65c-73b26b17d7f5)

![image](https://github.com/cmss13-devs/cmss13/assets/76988376/dd83152e-35d2-484a-b042-3e4169e05f25)

</details>

# Changelog
:cl: Drathek
add: Queen jellies now use designation rather than ckey for attribution
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants